Design comparison
SolutionDesign
Community feedback
- @besttlookkPosted over 2 years ago
hi, Great work. Below are some points i like to make:
- Shadow is too harsh for dropdown. Shadow should be subtle.
- Dropdown should close automatically when clicking outside.
- Add hover effect for fropdown item(for large screen)
- for large screen the hero section should cover whole view-port height. Gap below looks weird.
- For mobile add overlay of dark color below menu. Currently you are using shadow. Also when clicking outside the menu(i.e on overlay) menu should close.
- Use HTML semantic tags for better accessibility. Wrap the main content with <main> tag rather than <div>
Good luck, Happy coding
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord