Design comparison
SolutionDesign
Solution retrospective
All feedback apreciated.
Community feedback
- @vanzasetiaPosted about 3 years ago
👋Hi Manuel Salazar! I can't preview your solution, it seems like there is something wrong, try to fix it. So, I'm going to give my feedback based on your files:
- For any decorative images you should leave the
alt=""
empty and addaria-hidden="true"
to make sure all screen readers ignore those images. - For any text content, you should wrap it with meaningful tag like paragraph and heading tags. It's important for accessibility.
- You can swap the container
div
withmain
tag to make all page content live inside the landmark. - You should always styling elements by selecting the class name. Using
id
is unnecessary since it will increase the specificity and create issues. Try to use BEM naming convention instead. - Use
rem
or sometimesem
unit instead ofpx
units. Usingpx
will not allow the elements to scale based on the users needs.
That's it! Hopefully this is helpful!
Marked as helpful0@NorwyxPosted about 3 years ago@vanzasetia Very helpful, I'll try to correct everything, thx!
0 - For any decorative images you should leave the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord