HTML, CSS and flexbox.

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Manuel Salazar! I can't preview your solution, it seems like there is something wrong, try to fix it. So, I'm going to give my feedback based on your files:

  • For any decorative images you should leave the alt="" empty and add aria-hidden="true" to make sure all screen readers ignore those images.
  • For any text content, you should wrap it with meaningful tag like paragraph and heading tags. It's important for accessibility.
  • You can swap the container div with main tag to make all page content live inside the landmark.
  • You should always styling elements by selecting the class name. Using id is unnecessary since it will increase the specificity and create issues. Try to use BEM naming convention instead.
  • Use rem or sometimes em unit instead of px units. Using px will not allow the elements to scale based on the users needs.

  That's it! Hopefully this is helpful!

  Marked as helpful

  0

  ---

  

  Manuel Salazar•330

  @NorwyxPosted about 3 years ago

  @vanzasetia Very helpful, I'll try to correct everything, thx!

  0