Design comparison
SolutionDesign
Solution retrospective
Hi! Feedback is more than welcome! I am sure there are "cleaner" ways to do this challenge. Regards!
Community feedback
- @muhammadshajjarPosted about 3 years ago
Hey, awesome work on this one 👍 The layout looks good and responds well on all viewports but it is not perfectly centre on viewports greater than 1440px, you would see the left alignment of hole content
margin: 0 auto
on body would fix it.🙌Some more suggestions that would make your solution more cleaner are
- I prefer to put a
header
outside ofmain
element - Avoid adding those words that relate to graphics such as logo, image, and for decorative images use alt attribute as a Blank
atl=“”
and usearia-hidden="true"
orrole="presentation"
. In your case.service-images
are decorative - Hover states on Social media images are missing, Try to add them too.
Marked as helpful0 - I prefer to put a
- @iamcgsPosted about 3 years ago
Thanks for your feedback. Your comments are really helpful :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord