HTML, CSS & Bootstrap

Community feedback

• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hey there,

  Bootstrap seems like a bit of an overkill for such a small component. It's fine to use it if that's what you wanna practice but it can create more problems than it's worth. This is just my opinion of course, your solution seems fine at the first glance ^^ I have a few suggestions though:

  1. One of the main problems coming from Bootstrap is the use of divs. Divs don't carry much meaning, we have a selection of semantic tags instead that I'd encourage you to use. For your container main would be perhaps a better element. For your button, you should definitely use a button element. And - this could be argued, I suppose, but - instead of divs for your "boxes" you could use sections.

  2. In the "Why Us" section you have a list you should break into smaller bits. At the moment, if you look at "Tutorials by industry experts Peer & expert code review Coding exercises Access to our GitHub repos Community forum Flashcard decks New videos every week" as one, it doesn't make much sense, does it? ^^ I'd use a ul here and an li for each list item.

  3. br shouldn't be used for styling. There's CSS for that! Here's the MDN article of br that explains what it's used for. Headings and paragraphs have a display: block by default so there's no need for a line break. You'd like to add some space between your elements? Use padding/margin for that ^^

  4. You're missing a border-radius from your component but this is really a small issue compared to the rest :)

  Overall you did good though! Next step would be to stop to think what purpose your elements serve. Don't think about styling alone because there are plenty of users who aren't able to see it and you have to cater for them too :)

  0

  ---

  

  MANISHA SAMANTA•50

  @manishasamantaPosted almost 3 years ago

  @FluffyKas Thanks for your suggestion. I learned a lot from your feedback. 😊

  0