Design comparison
Solution retrospective
I am proud of my self, that I cretaed the first application and deployed as live application. Though it is simple application I did it my first time. I took online refrence to complte this solution, from Next time onwords I will put my own efforts to complete the solution. While doing this soltuion I learned CSS stuff and GIT.
What challenges did you encounter, and how did you overcome them?I faced the difficulty while writing the CSS code. I couldn't able to figurout the exact matched solotion according to the desgin. so I took refrences from internet and try to replicate those.
What specific areas of your project would you like help with?CSS techiniques.
Community feedback
- @kalebemaxPosted 2 months ago
For the image issue you should try and fix like this: <img src="images/image-qr-code.png" alt="frontend mentor qr code">
And also im not getting to see the live site you must solve that problem too.
0 - @snigdha-sukunPosted 2 months ago
-
Semantic HTML:
The solution effectively uses semantic HTML, which is great to see. -
Accessibility:
To enhance accessibility, I recommend addingrole="main"
to the<div>
that contains the primary content. This will help screen readers better understand the structure of the page. -
Responsiveness:
Unfortunately, I was unable to assess how well the layout adapts to different screen sizes, as the live website link provided did not work for me. -
Code Quality:
The code is well-structured, readable, and designed with reusability in mind. Excellent work on this front. -
Design Consistency:
Similar to the responsiveness, I couldn't evaluate the design accuracy due to the live website link not working.
If you fix the issue with the live website link, I'd be happy to provide further feedback on the layout and design consistency. Overall, you're on the right track!
0 -
- @MuhammadKhan21525Posted 2 months ago
Overall your QR-CARD IS GREAT BUT THE PICTURE IS NOT VISIBLE. CAN YOU ENSURE THAT?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord