HTML, CSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  Hi, Martha! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 It's a great thing that you are able to finish this challenge without any media query! 👏

  About the image, in the current remote repo, the image is located on the same level as the index.html. Currently, it is trying to find the image in the QR/ folder, which is doesn't exist.

  Two things that I would like to suggest.

  • Firstly, set a max-width for the .QR_tab instead of a width. That way the card will be more responsive because it is allowed to shrink if needed.
  • Secondly, make the body element as a flex container to center the card instead of using margin on the card element itself. It will make sure that the card would always in the middle of the page regardless of the screen sizes of the users' devices.

  I hope this helps! Keep up the good work! 👍

  Marked as helpful

  1

  ---

  

  Martha Eason•30

  @marthaeasonPosted over 2 years ago

  @vanzasetia Thank you! Super helpful :)

  0

  

  Vanza Setia•27,775

  @vanzasetiaPosted over 2 years ago

  @marthaeason No problem! I'm happy that it is super helpful to you! 😁

  0
• 

  Abdul•8,540

  @SamadeenPosted over 2 years ago

  Hey!! Cheers 🥂 on completing this challenge.. . Here are my suggestions 1.You should use <main class="QR__tab"> instead of <div class="QR__tab">. 2. There is an issue with your image.. I think you dont have your image in a folder so its best you should rewrite the path <img src="image-qr-code.png"> dont forget to add an alt text. 3. You can also set the max-width to 100% for responsiveness . Regardless you did amazing.. Happy coding!!!

  Marked as helpful

  0

  ---

  

  Martha Eason•30

  @marthaeasonPosted over 2 years ago

  @Samadeen thank you!

  0
• 

  Syahrizal Ardana•330

  @GombengPosted over 2 years ago

  the problem is in : <img src="QR/image-qr-code.png" alt="QR code" />

  since ur image file isn't in the folder, the html should goes: <img src="image-qr-code.png" alt="QR code" />

  1

  ---

  

  Martha Eason•30

  @marthaeasonPosted over 2 years ago

  @Gombeng success! Thank you so much!

  1

  

  Syahrizal Ardana•330

  @GombengPosted over 2 years ago

  @marthaeason urwelcome

  0