HTML, CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Pierre, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • add descriptive text in the alt attribute of the image
  • remove all margin from .nft-item-container and .nft-item class because with flex they are superfluous
  • use min-height: 100vh instead height to body
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  1

  ---

  

  Pierre Allard•135

  @RondellAllardPosted over 2 years ago

  @denielden Great advice. Haven't done raw HTML in a while. Thanks!

  1