Design comparison
Solution retrospective
Another challenge. Would be happy to hear any comments, tips, or advice.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there ๐. Congratulations on successfully completing the challenge! ๐
- I have other recommendations regarding your code that I believe will be of great interest to you.
DECORATIVE SVG'S โจ๏ธ:
- The
alt
attribute is used to provide alternative text for images in HTML documents. Thealt
attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
- Now, when it comes to decorative
SVGs
, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
- Since these images do not convey any important information or functionality, there is no need for an
alt
attribute.
- So feel free to set the
alt
attribute as""
for decorativesvg's
, becausealt=""
will be skipped by screen readers they will consider the image as decoration
Example:
<img src="images/decorative.svg" alt="">
<img class="icon-image" src="assets/icons/icon-suvs.svg" alt="icon-sedan"> ๐ <img class="icon-image" src="assets/icons/icon-suvs.svg" alt="">
.
I hope you find this helpful ๐ Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1 - Account deleted
Hello Coder ๐
Your solution is greatโจ and congratulations for successfully completing an another newbie challenge๐
and there is small suggestion that might be helpful for you
min-height :
You can use min-height instead of height
because height will put your element to a size of 100% of it's container. min-height will put the element to min 100% of the container size.
if we set
min-height: 100vh
then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in spaceand it will helpful when you make responsive solutions
Images are for decoration : The alt attribute provides alternative information for an image if a user for some reason cannot view it and screen readers use the alt attribute to convey the message about the image
And when the image don't have a significant meaning or image is just there for decoration we don't write any value in alt attribute
so feel free and remove alt attribute value
<img class="icon-image" src="assets/icons/icon-sedans.svg" alt="">
And I also recommend you to check out my solution that will definitely going to help you
Hope that was helpful ๐
Marked as helpful1@Tonylgr21Posted over 1 year agoThank you very much. I'll consider all my mistake for next time!@MrSandipSharma
0Account deleted@Tonylgr21
I am glad that was helpful for you๐
Marked as helpful0 - @NehalSahu8055Posted over 1 year ago
Hello Coder ๐.
Congratulations on successfully completing the challenge! ๐
Few suggestions regarding design.
- Just a little miss
- The styling of button is not as per fem design you need to make the button transparent on hover.
button:hover{ background:transparent; }
I hope you find this helpful.
Happy coding๐
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord