Design comparison
Solution retrospective
Kindly rate this and give me any critical feedback so I can keep on improving, Thank you.
Community feedback
- @Dami-MoorePosted over 2 years ago
Good attempt! @OgheneCodes. A few suggestions. For the layout, you can remove "margin-left: 5%" from the seconddiv and thirddiv classes in your style.css
Concerning accessibility issues, the <img> tag will require an alt attribute which will enable your site to be accessible to all kinds of users. The value for the alt attribute is a description of the image, that can be accessed by, for example, someone with visual impairment using your site.
Also, headers also help accessibility, so you can change the <p class="title"> tags to h1 tags but still maintain the styling.
Your site is also responsive, only that the buttons are a bit off position on mobile view, I'm thinking that might have been an oversight.
For me, it took a while to really come to understand how to use semantics in html (I'm still learning) and I know it really helped my coding.
I hope this was helpful! Happy Coding!
0@ogheneCodesPosted over 2 years ago@Dami-Moore Thank you so much stopping by to give me this honest feedback, it mean alot to me, corrections noted! Thanks ones more Dami
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord