Design comparison
SolutionDesign
Community feedback
- @melwyntPosted over 2 years ago
Hi Erick! 👋 Congrats for your first challenge! 🥳
There's only one minor issue in your report:
Page should contain a level-one heading
.You can easily fix this by replacing the
h2
tag with anh1
tag.In your CSS, try to replace all the
pixel
units withrem
unit. This will improve accessibility if the user is zooming the page in or out.You could for example add this in your CSS:
html { box-sizing: border-box; font-size: 62.5%; // 1rem = 10px, 10px/16px = 62.5% }
Then, instead of using
font-size: 15px;
, you can do:font-size: 1.5rem;
For more information regarding this trick, this stackoverflow answer is perfect: stackoverflow.com/a/58421428/7246315
Cheers and happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord