Design comparison
Community feedback
- @denieldenPosted over 2 years ago
Hi Rômulo, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- remove all
margin
fromcard
class - try to use flexbox to the body for center the card. Read here -> best flex guide
- after, add
min-heigth: 100vh
to body because Flexbox aligns child items to the size of the parent container - try to add a little
transition
on the element with hover effect - instead of using
px
try to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful0@romuloqueirozPosted over 2 years ago@denielden thank you for the feedback, i'm gonna read about it and improve my code. It was so helpful!!
1 - remove all
- @felontaPosted over 2 years ago
Eai @romuloqueiroz tudo certo ? cara primeiramente parabéns por ter conseguido codificar realmente ficou muito bom, somente um adendo/dica para você, quando for importar alguma imagem para seu código tente colocar "." antes do diretório da imagem, exemplo <img src="./images/illustration-hero.svg" alt="Musica">. para que volte um nível hierárquico e assim consiga acessar a sua img, caso ainda tenha duvida sobre acesse o link abaixo,
https://developer.mozilla.org/pt-BR/docs/Learn/Getting_started_with_the_web/Dealing_with_files
Feliz codificação 👏👏👏
Marked as helpful0@romuloqueirozPosted over 2 years ago@felonta Cara muito obrigado pelo feedback, vou dar uma olhada no link!!!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord