Skip to content
Submitted about 3 years ago

HTML, CSS

Ahmed•105
@Kirin02
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Order summary component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I feel like my code isn't professional at all so any helpfull advice would be appreciated!

Community feedback

  • Jannie Hansen•110
    @Jawha3Posted about 3 years ago

    Hello Kirin, I'm no expert at all but what I've been taught and trying to do more of, is use more html sematics and not so many div-tags.

    Also just want to point out that it seems we are not able to actually see the website, only the code - something must have went wrong when you uploaded the solution :)

    EDIT: Oh and also I just noticed you use "px" in your css - that I have been told is best to avoid in most cases and instead use "rem" and "em" where approbiate.

    Marked as helpful
    1
    Ahmed•105
    @Kirin02Posted about 3 years ago

    @Jawha3 Thank you, that was helpfull also, for the live page i uploaded it on github and activated Main branch and root file but it still not working i don't understand why

    0
    Jannie Hansen•110
    @Jawha3Posted about 3 years ago

    @Kirin02 I wish I could help you with that, but I am only just now about to start a challenge - so I have no knowledge on how to upload solutions yet :3

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord