HTML CSS

Community feedback

• 

  Agata Liberska•3,995

  @AgataLiberskaPosted over 3 years ago

  Hi @tesla-ambassador, it looks great! I noticed two things: not sure whether <article> is the best choice for the sections of your card. All three parts form one whole component, and an <article> is something that makes sense on its own and can be distributed independently. I would probably just use divs here, but there may be a better option. The second thing is a tiny detail and I don't know this design, so sorry if that's what it was supposed to look like - but all text is centered in column layout, except for the price - was that intentional?

  Hope this helps :)

  2

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 3 years ago

  @AgataLiberska Thanks for the feedback. I had used divs in the first place but now that I think about it, I agree that I should have stuck with them and the text centered in the column layout except for the price was intentional. I was experimenting hahaha... ( They should add emojis for windows users)

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hey, TeslaAmbassador! 👋

  Sorry, it took me a while to give you feedback for this challenge. 🙃 But good job on this one, of course! 👏

  I think it would be better if you gave the card component a fixed width (rather than a width dependant upon the width of the viewport) and then simply changed the width using a media query when the width of the screen becomes very small. This will make the dimensions and design of the card component more consistent across screen sizes and make it easier to work with.

  And rather than add margin-top: 10% to the body, add min-height: 100vh. That'll ensure that the body is always at least as high as the viewport itself and eliminate the need to add margin-top: 10% to create some space between the top of the page and the card component. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 3 years ago

  @ApplePieGiraffe Thanks for the feedback my good brother. I will improve on my solution based on the advice you have given to me. I didn't notice that I had given it a width based on that of the view port but sticking to a fixed width sounds like a better idea, I will get to that right away!

  2

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @tesla-ambassador

  NP! Keep coding! 👍

  0