@Islandstone89
Posted
HTML:
-
Remove
.underMain
, it is not needed. -
I would wrap all of the card content in a
<div class="card">
. Hence, your HTML structure would look like this:
<main>
<div class ="card">
--card content
</div>
</main>
- "Learning" and "Greg Hooper" should be
<p>
.
CSS:
-
I like to add
1rem
ofpadding
on thebody
, to ensure the card doesn't touch the edges on small screens. -
On the
body
, changeheight
tomin-height
- this way, the content will not get cut off if it grows beneath the viewport. -
Remove all widths and heights in
px
, except for the profile image. -
Add a
max-width
of around20rem
on the card, to prevent it from getting too wide on larger screens. -
font-size
must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
Remove all positioning and transform properties.
-
Remove
z-index
, it is not needed. -
I'm not sure this needs a media query , as the layout doesn't change. When you do need media queries , they must be in
rem
orem
.
Marked as helpful
@ameera-abed
Posted
@Islandstone89 Thank you so much for your valuable feedback. I really appreciate the time and effort you took to provide me with helpful insights. I want to ask how to make the container under the card I don't know if its shadow or container under the card please if you can help me in that also I cant determine the exact height and width for card if there any way I will fix all these thing soon thank you