Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML AND CSS

@AlanGLinares

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@dimar-hanung

Posted

Hello 👋, Amazing job on conquering the challenge! 🌟

I have some interest and feedback with your code

That i like:

  1. I appreciate the similarity of your results with the design, a bit different in scale and font but not bad
  2. html is pretty good, not too nested with combination semantic html 👍, just little mistake you can remove useless white spaces between body and main
  3. Responsive until galaxy fold screen size 👌

My Feedback:

  • Maybe you can use tools like prettier to format your code to be more beautiful ( TIP: set prettier configuration to format on save, make it easier )
  • You have import font, but not using it, you can add font-family: "Vollkorn", serif; in body styles

anyways overall is good, nice solution, hope it useful 🙌

Marked as helpful

0

@AlanGLinares

Posted

@dimar-hanung thanks.

0

@dimar-hanung

Posted

@AlanGLinares You're welcome!

0

@heisemmaco-dev

Posted

Hi AlanGLinares, i like the way you layed out web container but first you didn't use the right font-family which is in the style-guild.md, secondly your second text paragraph the font-size is too small.

I hope you fine this useful

0

@OluwadaraDaily

Posted

I think you can reduce the font points of the title a little bit for it to approximate the design

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord