Design comparison
Solution retrospective
Finally Did a Junior Level Project (Desktop version only) DO correct me & suggest me ways to improve thnks :)
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Tarun! Congratulations on completing this wonderful project, I think it's a pretty solid solution, it's really neat. Here's a few pointers to help fix your accessibility issues and HTML validation issues (I will not comment on your responsiveness cause you normally make desktop versions only although I'd like to see how great your mobile versions are cause you make really great desktop versions😁)
- In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
<main>
or<header>
or<footer>
you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link. - When you decide to use
<ul>
or<ol>
their only child element can be<li>
and therefore you can't have a<br>
as one of the child elements of your<ul>
this is bound to generate some HTML validation issues. - You might wanna use heading tags (
<h2> - <h6>
) in your<sections>
. In your case, you have two options, you can use<div>
instead of the<section>
because thediv
doesn't require you to add heading tags or you can make the headings to your sections<h2>
tags.
These adjustments will clear all your HTML validation issues and accessiblity issues.
Happy coding and keep up the good work! 👍
Marked as helpful0 - In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord