html, css

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @FloraBloomblue, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Pratyusha Majumder•280

  @FloraBloombluePosted about 2 years ago

  @correlucas definitely! I am going through your shared links. thankyou so much.

  0
• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @FloraBloomblue, some suggestions to improve you code:

  • For this challenge you want to use the Picture Element not the Background Image Property. The Background Image Property is mainly used on decorative images

  Picture Element will allow your to switch between images in different breakpoints and makes your site load faster by saving bandwidth.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:

  https://www.w3schools.com/html/html_images_picture.asp

  https://web.dev/learn/design/picture-element/

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  Happy Coding! 👻🎃

  Marked as helpful

  0

  ---

  

  Pratyusha Majumder•280

  @FloraBloombluePosted about 2 years ago

  @vcarames thankyou for helping me. I will go through your shared links.

  0
• 

  LarryTheFatCat•50

  @LarryTheFatCatPosted about 2 years ago

  Hey!

  Nice work on this challenge!

  Couple things:

  1.- Great work on not getting any accessibility issues as well as no issues on validation report! 2.- Good Job on getting the color perfect! 3.- Only issue I believe that should be fixed and updated is the for the image compared to the actual card box, if you can please fix it that would be great...

  Overall, good job!

  Marked as helpful

  0

  ---

  

  Pratyusha Majumder•280

  @FloraBloombluePosted about 2 years ago

  @TwoThreeTwo okay. I shall definitely work on the 3rd.

  0