HTML, CSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Marawan Mohamed! 👋

  Nice job! 👍

  I suggest,

  • Decreasing the font-size in the desktop layout (it's quite big at the moment).
  • Rounding the corners of the component a little (like the original design).

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Marawan Mohamed•90

  @marawanmohamed9876Posted about 4 years ago

  @ApplePieGiraffe Thank you for your feedback, I will make these changes now and happy coding to you also 😁

  0
• 

  Roman Filenko•3,335

  @rfilenkoPosted about 4 years ago

  Hey, what issue are you implying to ? Here some fixed and improvements you can do:

  • don't use id's for styling;
  • it's better not to set margin, padding in %;
  • set max-width instead of just width on some containers.

  Cheers, Roman

  1

  ---

  

  Marawan Mohamed•90

  @marawanmohamed9876Posted about 4 years ago

  @rfilenko thank you for your feedback. I will make these changes

  1