Skip to content
Submitted about 3 years ago

HTML CSS

Sujeet Kumar Manjhi•40
@alias01
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please give some feedback so that I can improve. I recently started using BEM structure and following that. Any suggestion or anything which I have been doing wrong. Thanks in Advance.

Community feedback

  • Ken•4,915
    @kens-visualsPosted about 3 years ago

    Hey @alias01 👋🏻

    I have some suggestions to help you fix the accessibility issues and some other things.

    • In your markup, <div class="profile-card">...</div> should be <main class="profile-card">...</main> and <div class="attribution">...</div> should be <footer class="attribution">...</footer>. These will fix the accessibility issues. Don't forget to generate a new repot once you fix the issues.
    • The alt tag of the profile picture should have the person's name, like this: <img class="profile-card__image" src="./images/image-victor.jpg" alt="Victor Crest">

    I hope this was helpful 👨🏻‍💻 other than that, you did a great job, well donne. Cheers 👾

    Marked as helpful
    1
    Sujeet Kumar Manjhi•40
    @alias01Posted about 3 years ago

    @kens-visuals thanks for the feedback. I will use your suggestion.

    0
    Ken•4,915
    @kens-visualsPosted about 3 years ago

    @alias01 you're welcome 😇

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord