Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

html css

ameera 80

@ameera-abed

Desktop design screenshot for the Social links profile coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Dylan 290

@dquinn089

Posted

Nice work! The only thing is that this is suppose to be a profile to consolidate social media links, but your code doesn't include an a tag to incorporate these links. You should us ul and li instead of the div elements, as well as including an a tag inside the li elements.

Instead of:

<div class="social_media">
        <div class="social_media_account">GitHub</div>
        <div class="social_media_account">Frontend Mentor</div>
        <div class="social_media_account">LinkedIn</div>
        <div class="social_media_account">Twitter</div>
        <div class="social_media_account">Instagram</div>
</div>

do:

<ul>
        <li><a href="#">GitHub</a></li>
        <li><a href="#">Frontend Mentor</a></li>
        <li><a href="#">LinkedIn</a></li>
        <li><a href="#">Twitter</a></li>
        <li><a href="#">Instagram</a></li>
</ul>

Hope this helps, happy coding!

0

ameera 80

@ameera-abed

Posted

@dquinn089 thanks for advise I will change the code to ul

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord