html, CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Thanks for sorting, David. There are quite a few small 'under the hood' changes I can suggest for your code that I hope you find helpful

  1. Alt text doesn't need to say 'image of' because it is already announced as an image before the alt is read out

  2. You need to place all text inside html tags that are made for presenting text, like paragraphs or headings or list items (not divs or spans on their own, although you can still wrap text in spans that have classes on to help with styling)

  3. I would recommend you learn more about css specificity and naming conventions to make your css more maintainable on larger projects. You're using a lot of nesting and ids and element selectors at the moment. I'd expect to see styles done using single classes in the main.

  4. I'm not sure you're fully understanding the implications of using position absolute and transform translate as a centering/layout method. Try using methods like flexbox and research what absolute positioning does to the DOM. To be clear, you can use that method sometimes, but I wouldn't expect to see it often and in modern css there is almost always a better way now.

  I hope all that's helpful for your learning ☺ Keep going

  0

  ---

  

  David Ouma•270

  @daudi13Posted almost 4 years ago

  @grace-snow Thank you

  0
• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi David, your code link is pointing to the wrong challenge on this one

  0

  ---

  

  David Ouma•270

  @daudi13Posted almost 4 years ago

  @grace-snow sorry let me work on that

  0

  

  David Ouma•270

  @daudi13Posted almost 4 years ago

  @grace-snow done!

  1