Skip to content
Submitted almost 3 years ago

HTML CSS

Ngoc Tran•40
@tranngocteam79
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi guys, Could you guy please take a look and give me some feedback? I have just learned HTML & CSS for 2 months.

Community feedback

  • Web Wizard•5,690
    @rsrclabPosted almost 3 years ago

    Hi, @tranngocteam79 ~ It really looks great! Congratulate on your first solution to Frontend Mentor challenges. The only thing I want to recommend is to try BEM structuring. This is really good one to try it, I think.

    Happy coding.

    Marked as helpful
    1
    Ngoc Tran•40
    @tranngocteam79Posted almost 3 years ago

    @tymren608 I restructured my CSS class to BEM naming conventions as you suggested. I'm not sure I name it correctly but I tried my best. Thank you Tymur!

    0
  • DanielK•440
    @DanK1368Posted almost 3 years ago

    It looks good :)

    I have one suggestion. I would add a border-radius to the hover effect of the image, the same one that you applied to the image itself. It will look nicer.

    Marked as helpful
    1
    Ngoc Tran•40
    @tranngocteam79Posted almost 3 years ago

    @DanK1368 Hey Dan! I added border-radius to image when hovered. Thank you!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord