Skip to content
Submitted about 2 years ago

html css

Guneet Bakshi•10
@guneet07
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Suggestions are welcome !

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Guneet Bakshi, Congratulations on completing this challenge!

    Your solution its almost done and I’ve some tips to help you to improve it:

    1.The colors you’ve used are a little bit different from the original colors.When you download the project files there’s a file called style-guide.md where you can find information such as font-family, hsl color codes, device sizes and the font-size for the headings.

    2.Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

    3.A better way to work this solution image, the product image is by using <picture> to wrap it on the html instead of using it as <img> or background-image (with the css). Using <picture> you wrap both images (desktop and mobile) and have more control over it, since you can set in the html when the images changes setting the screen size for each image.ote that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image.

    Here’s the documentation and the guide to use this tag: https://www.w3schools.com/tags/tag_picture.asp

    See the example below:

    <picture>
  <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
  <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
</picture>

    4.Add the correct font for the main heading of this component. First of all you need to choose the font using Google Fonts https://fonts.google.com/ and import the code to drop on your CSS/HTML:

    This is the font for the H1: font-family: 'Fraunces', serif;. There's two ways to import the font:

    • Using the html and inserting it to the <head>
    <head>
<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&display=swap" rel="stylesheet">
</head>
    • Using the CSS and adding to the first line of the CSS sheet:

    @import url('https://fonts.googleapis.com/css2?family=Fraunces:opsz,[email protected],700&display=swap');

    👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

    ✌️ I hope this helps you and happy coding!

    1
    Guneet Bakshi•10
    @guneet07Posted about 2 years ago

    @correlucas thanks, this was really helpful. I will try this.

    0
    Guneet Bakshi•10
    @guneet07Posted about 2 years ago

    @correlucas your code is showing 404 error, please check.

    0
  • Alba•70
    @albscrPosted about 2 years ago

    hello! for some reason the page says "error" but when I enter your code it comes out fine (I think something must be wrong with your link when uploading the page), It looks good, the button and the yellow numbers are out of the color of your palette. Also to help you to make your page responsive, try the code in your image:

    .img { width: 100%; height: auto; } congratulations!

    0
    Guneet Bakshi•10
    @guneet07Posted about 2 years ago

    @albscr thanks. I'll try this one, and try to reupload my code

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord