HTML, CSS

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted almost 3 years ago

  Greeting @xchen1778 ,

  I have few suggestions regarding your solution:

  • Use a landmark footer for the attribution and <Footer> should be outside the<main > You can read more about "HTML5 landmark elements are used to improve navigation" .

  • The alternative text is needed on that image for assistive tech and SEO search engine optimization . So it needs to contain a description like Qr code .

  • Use min-height: 100vh; instead height: 100vh. using vh (viewport height) units allow the body to to grow taller if the content outgrows the visible page.

  • It's not recommended to use px for font size . Using px won't allow the user to control the font size based on their needs.

  Overall , your solution is good. Hopefully this feedback helps.

  0