@Hassiai
Posted
Replace <div class="qr-body"> with the main tag and <h2> with <h1> to fix the accessibility issues. accessibility semantic likn : http://web-accessibility.carnegiemuseums.org/foundations/semantic/ https://uxdesign.cc/semantic-html-the-foundation-of-web-accessibility-e5bbecad7c17
The body has a wrong background-color, give it a background-color of light-gray.
Give h1 and p the same font-size of 15px which is 0.9375rem, text-align: center,the same margin-left, margin-right and margin-top values. Give p a margin bottom value.
For a responsive content,
- Give .qr-body a fixed max-width value and a padding value for all the sides
max-width:320px which is 20rem padding:16px which is 1rem/em
- Give the img a max-width of 100% and a border-radius value, the rest are not needed.
To center .qr-body on the page using flexbox or grid,
- USING FLEXBOX: add min-height:100vh; display: flex; align-items: center: justify-content: center; to the body
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
- USING GRID: Add min-height:100vh; display: grid place-items: center to the body
body{
min-height: 100vh;
display: grid;
place-items: center;
}
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING