HTML / CSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 4 years ago

  Hey, Daniel Juergens! 👋

  I gave you a bunch of feedback earlier, but somehow your solution went missing or something (or there was a glitch, IDK).

  Anyway, good work on this challenge! 👍

  And congratulations upon completing your first Frontend Mentor challenge! 🎉

  I suggest,

  • Using flexbox to center the card component in the viewport. Adding the following code snippet to the body should do the trick!

  display: flex;
  align-items: center;
  justify-content: center;
  

  • It looks like you have quite a few media queries in your solution, but they aren't really necessary for this design because hardly anything about the card component needs to change when the screen is resized. Simply give the card component a max-width and a fixed height so that it looks the same when the screen is resized and the width only decreases if the viewport gets really, really small.
  • Setting min-height: 100vh on the body will help nicely center the card component, too.

  Keep coding (and happy coding, as well)! 😁

  2

  ---

  

  Daniel Juergens•90

  @DanielJ1337Posted about 4 years ago

  Hey,

  thank you so much for your feedback! Yeah, this positioning stuff is still not 100% clear.

  But it keeps getting better :)

  Have a phenomenal week. 👍

  0