HTML- CSS

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • The element <p class="change">Change</p> should be a anchor tag (<a>) and not a <p>, since an element has a :hover state and has a pointer cursor it is considered an interactive element (buttons, links, etc).

  • The <picture> tag can be useful when you need to provide different images for different viewports, but in this specific challenge, it's not necessary. You can directly use the <img> tag to include the image in your solution.

  CSS 🎨:

  • Use padding: 1rem; instead of margin: 1rem; in the body element to remove the scrollbar on desktop devices.

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.

  I hope you find it useful! 😄

  Happy coding!

  0

  ---

  

  Tamana•210

  @Tamana123-2Posted over 1 year ago

  @MelvinAguilar Hi! I hope you are doing great with life struggles. Thanks Melvin Aguilar your recommendations would help me along the way of coding journey. Looking forward for your more advise in this path as a mentor. Nice time.

  0