@correlucas
Posted
👾Hello @AndresF-SanchezG, Congratulations on completing this challenge!
Great code and great solution! I’ve few suggestions for you that you can consider adding to your code:
1.Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>
. For this solution you wrap everything inside a single block of content using <div>
or <main>
(better option for accessibility) and put inside the whole content <img>
/ <h1>
and <p>
.
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
2.Use units as `rem` or `em` instead of `px` to improve your performance by resizing fonts between different screens and devices.
To save your time you can code your whole page using `px` and then in the end use a VsCode plugin called **px to rem** here's the link → [**https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem**](https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem) to do the automatic conversion or use this website [https://pixelsconverter.com/px-to-rem](https://pixelsconverter.com/px-to-rem)
**✌️ I hope this helps you and happy coding!**