Daniel 🛸• 44,230
@danielmrz-dev
Posted
Hello @arowstev!
Your project looks very good!
I have a couple of suggestions for improvement:
- You uploaded your project to Github with the images outside the folder assets. Since they are not inside the folder anymore, your code won't find them with this path:
<img id="picone" src="assets/images/illustration-article.svg" alt="">
You can fix that by removing the folders from the image path, like this:
<img id="picone" src="illustration-article.svg" alt="">
-
It's a good practice to keep the assets in separate folders. It helps with the organization.
-
Also, add an alternate text for the image.
The alt attribute provides alternative information for an image if a user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader).
I hope it helps!
Other than that, great job!
0
