Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML, CSS

@ahmed-abohmaid

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


It is close or not?

Community feedback

@ralacerda

Posted

Hey, awesome job!

You got everything right and your code is really clean. People usually show the attribution at the bottom (but I can understand if you hide it to keep the design clean). You can try using position-absolute to place it at the bottom without moving the card.

If you want to fix the accessibility problems you can use a <main> tag instead of a <div> in your box element. It should fix both warnings about landmarks.

You can include an empty alt attribute to your img tag, or describe that it is a qr code.

Marked as helpful

1

LEANDRO 50

@JESUS-LEANDRO

Posted

@ralacerda obrigado pelas dicas irei bota em pratica.

2

@ahmed-abohmaid

Posted

@ralacerda Thanks, I will make these changes.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord