Design comparison
SolutionDesign
Community feedback
- @denieldenPosted almost 3 years ago
Hi Sheldon, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - add
overflow: hidden;
tobigimg
class - try to add a little
transition
on the element with hover effect - instead of using
px
try to use relative units of measurement -> read here
Overall you did well :)
Hope this help and happy coding!
Marked as helpful0@SheldonFamPosted almost 3 years ago@denielden Hi Deniel, thank you so much for your advise. I will check my code and implement on it.
1@denieldenPosted almost 3 years ago@SheldonFam You are welcome! I would really appreciate if you mark my comment as helpful if it helped you, thank you very much :)
0 - add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord