html, css

Community feedback

• 

  Hamzat Lawal•560

  @EngineerHamzieyPosted over 2 years ago

  Hello Pratyusha, You have done a great job.

  • I noticed the desktop version isn't centred, to make it stay at the center of the screen ( on all screen size)

  body {
        min-height:100vh; /*this is important*/
       display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
  }
  

  adding this will make it both vertically and horizontally centered

  • Words written in uppercase in HTML might be spelled word by word by screen readers(instead of being pronounced as a single word), so I'll recommend that you write the text(sedans, suvs and luxury) in lowercase in your HTML then transform it to uppercase using your CSS.

  I hope you find this useful

  0

  ---

  

  Pratyusha Majumder•280

  @FloraBloombluePosted over 2 years ago

  @EngineerHamziey Thankyou . I will work on it. Though , I have a doubt, I previously centered the body tag with those attributes only but then I thought maybe the container should be centered and I did that. That's why I changed it. Thanks for notifying me!

  0

  

  Pratyusha Majumder•280

  @FloraBloombluePosted over 2 years ago

  @EngineerHamziey another doubt, why is min-height:100vh; important?

  0

  

  Hamzat Lawal•560

  @EngineerHamzieyPosted over 2 years ago

  @FloraBloomblue The min-height CSS property sets the minimum height of an element. It prevents the used value of the height property from becoming smaller than the value specified for min-height.

  You can experiment with it to understand better Also, I have done some some correction and explanation to someone's code you can check it,I think it will help...

  github repository link

  live site link

  if you notice anything wrong, feel free to correct me I am not perfect, I am a beginner, I am open to correction and suggestions and I am wiling to learn more I'm doing this because I hope it will help feel free to ask questions,

  I hope you found this helpful.

  Marked as helpful

  0