HTML + CSS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 3 years ago

  Hi Zdravko, I took some time to look at your solution and you did a great job!

  Also I have some tips for improving your code:

  • add main tag and wrap the card for Accessibility
  • add descriptive text in the alt attribute of the image
  • Centering a div with absolute positioning is now deprecated, it uses modern css like flexbox or grid, so remove margin, position, top, left and transform properties from .container class because with flex they are superfluous
  • add min-heigth: 100vh to body because Flexbox aligns to the size of the parent container

  For fix the top image in the background just put more specific background properties to the body:

  background: url("../img/pattern-background-desktop.svg") no-repeat top center;
  background-size: contain;
  background-color: #e0e8ff;
  

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  1

  ---

  

  Zdravko•420

  @Zdravko93Posted almost 3 years ago

  @denielden Thank you very much! I appreciate you taking time to inspect my code, and giving it a nice, neat feedback. I will do as you advised. Thanks again!

  1