PhoenixDev22• 16,950
@PhoenixDev22
Posted
Hi Channah Miryam,
Congratulation on completing another frontend mentor challenge.Excellent work! I have some suggestions:
- About
<h1>it is recommended not to have more than one h1 on the page. Multiple<h1>tags make using screen readers more difficult, decreasing your site’s accessibility. In this challenge, as it’s not a whole page, you can have<h1>visually hidden withsr-only. Then you can swap those<h1>with<h2>
- In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty
alt=""andaria-hidden="true"attributes to make all web assistive technologies such as screen reader ignore those images, always remember to include interactive elements like(button, textarea,input, ..)
- In this challenge, what would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
- There are some unnecessary div’s need to be HTML.
- Adding
rel="noopener"orrel="noreferrer"totarget="_blank"links. When you link to a page on another site usingtarget=”_blank”attribute, you can expose your site to performance and security issues.
- In order to center the card on the middle of the page , you can use the flex or grid properties and
min-height: 100vhto the<body>. Add a little padding to the body that way it stops the component from hitting the edges of the browser.
- Add
border-radiusandoverflow hiddento the main container that wraps the three cards so you don't have to setborder-radiusto individual corners.
hopefully this feedback helps.
Marked as helpful
0
