HTML & SCSS

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Ratna Kumar Singh!

  On my mobile device the productive__img is overflowing and causing a horizontal rule appear.

  Also the Get Early Access Today needs to be a section instead of a div, since it's also an important part of this site.

  More feedback:

  • For the button inside the form, I recommend to add type="submit".
  • On my mobile (360px width), all the text is cramped. Try to reduce the padding.
  • Nesting is a great feature from Sass, but don't overuse it though. It will make the specificity higher than it should. You can just select directly the parent class and since you're using BEM, you can try this method:

  .productive {
    // Some Styles
    
    &__text {
       // Some Styles
    }
    
    &__header {
       // Some Styles
    }
  }
  
  /* CSS */
  .productive {}
  .productive__text {}
  .productive__header {}
  

  • That way, you have a cleaner CSS and Sass code. It's also benefits you in the future, since you don't have to get confused with the nesting.
  • Also just @import all the font families with one @import, it will make your site load faster 🚀.

  That's it! Hopefully this is helpful!

  1