HTML & SCSS and JS for share options pop up

Community feedback

• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  well looks like you have a good start to this but here are a few things I saw.

  1. at 805px wide browser you can see you social menu popup going outside the right side of the browser.

  2. at mobile width of 375px your social popup button is over top of a social icon.

  3. I am not sure you need to be using the transition property at all. You do not need animation transitions between the changing screen widths

  0

  ---

  

  Андрій Рогов•1,155

  @Andrii-RohovPosted over 3 years ago

  Thanks for pointing out the mistakes i made. It woud be fun to try and fix them, without breaking other stuff) And transition i use only to practice, to hardcode my brain, so i woud understand this property, and know how it works. I am very gratefull for feedback

  1

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Andrii-Rohov ok well if you are just using that property to practice then EXCELENT 🌟

  Also I would not call the issues mistakes just learning. So many moving parts and pieces to watch . This is not easy but you have a good start it seems

  0

  

  Андрій Рогов•1,155

  @Andrii-RohovPosted over 3 years ago

  @palgramming Thanks again, i've been going in and out of learning/practicing fron-end in a couple of years now, not realy trying my best. But covid had opend my eyes, that IT is a great proffession, and now i have motivation to keep going. So i'm not like a complete newbie, i've been a newbie for a long time now)

  1

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Andrii-Rohov yes totally it does seems overwhelming at times with so much to learn. I have a hard time focusing I will do JS one month then React another and then go back to Python. I keep jumping around a lot but hopefully at some point I will end up at a destination I am happy with

  all we can do is try to keep coding every day

  0