HTML and Sass

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The alt tag description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, inside the del element you will want to add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Hesam•420

  @hesam-fattahiPosted almost 2 years ago

  @vcarames Hey!👋 Thank you so much for your comment. I've updated the code changing article to main and updating the alt text for the image. As for the old price, is it better to use del with an element using sr-only or using p with text-decoration in CSS?

  Again, thank you so much for your help. 🙏🙏

  0

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @hesamf01

  Glad I could help!

  For semantic reasons and since it will automatically strike a line through the text, it is better to use the del.

  Keep it up!

  Marked as helpful

  1

  

  Hesam•420

  @hesam-fattahiPosted almost 2 years ago

  @vcarames 🙏🙏🙏

  0