HTML and pure CSS with flex

Community feedback

• 

  Fastcheettahh•280

  @fastcheetahPosted about 2 months ago

  Hey overall nice work on your project I really like it and how you made your name in the challenge a different color But I think you made some common mistakes like naming your css file samo.css instead of index.css like your index.html file because i think if you work for bigger companies youd be making different html files and css files you would need to link to and giving them different names would be a hassle and confusing. "" Also I noticed when you were using media-queries on your container you gave it a max-width and didnt give your width value a percentage value. "" The use of a max - width according to what I know is to make sure your element doesnt pass a specific limit when you put a percentage value like 100% of your page and the min-width value vice-versa. "" Also use rem values instead of pixel values when putting font-size. "" An extra tip I would think would be nice for you to know is the box-sizing property as it can be helpful and you should also know about the css hard reset where you can apply this E.G" *{ box-sizing: border-box;
  // an example of the box-sizing value } ' If you found this helpful or you learnt anything could you do me a favor and mark this comment as helpful ''" Thank you and nice work on your project

  Marked as helpful

  0