Skip to content
Submitted about 2 years ago

HTML & CSS-only challenge

Rémi•20
@remi-vieille
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • バレンタイン 😈•64,170
    @VCaramesPosted about 2 years ago

    Hey @remi-vieille, great job on this project!

    To help keep your CSS code organized and easier to use, I suggest implementing CSS Variables. This will come in handy when building large websites, using light/dark mode, etc…

    It’ll look something like this:

    :root {
  --primary-color: value;
  --secondary-color: value;
  --tertiary-color: value;
}

    And to use the variables you’ll use the var() function. So it’ll look like this.

    h1 {
color: var(—primary-color);
}

    Heres are some articles regarding CSS Variables.

    You can also take a look at my projects and see how I use it.

    https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties

    https://www.w3schools.com/css/css3_variables.asp

    Happy Coding!

    Marked as helpful
    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello @remi-vieille, congratulations on your first solution!

    Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:

    You can use <main> to replace the <div> containing the whole content, <div> is a block element without meaning and <main> is a tag the shows which is the most important block of content in this page.

    I saw that for some properties you’ve used rem and for others px. In this case, it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi Rémi, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    Prefer to use rem over px to have your page working better across browsers and resizing the elements properly

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    0
  • Raja Junaid Farooq•390
    @Raja-JunaidPosted about 2 years ago

    Hello Remi! Congratulation on completing this challenge. I have some tips for you:

    (1)- Keep the webpage neat and clean

    (2)- Keep your work as decent as possible when creating a webpage.

    (3)- Never forget to place comments in your code.

    I hope this helps you

    Keep Coding and Keep Practicing.

    HAPPY CODING!

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord