HTML and CSS

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted over 2 years ago

  Hi

  Lots of the same issues in this as your other card solution but this has lots more problems with the html I'm afraid.

  In addition to previous feedback

  • paragraphs are for whole sentences, you can't split what is read as one sentence into multiple paragraph tags
  • decorative images should have empty alt attributes
  • anything with a hover in the design must be an interactive element in the html. That is essential

  Marked as helpful

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted over 2 years ago

  Ps. Please 🙏 Indent your code consistently. It is very hard to read like this

  Marked as helpful

  0

  

  Slideur•180

  @SlideurPosted over 2 years ago

  @grace-snow

  Hi,

  Thank you for your comment. I can improve on html and css. I'm using the paragraphs for whole sentences. I won't split my sentences in a multiple paragraph tags. I didn't know that it was necessary for decoratives images should have alt attribute. I thought it was necessary tu use the attribute alt for the decorative image. I didn't understant the last information about an interactive element in the html. Should I create an element interactive in a webpage for the design, the user ? I'm trying to use all yours advices. I'm very sorry to ask some questions. I'm redoing for me the code QR and nft with yours advices. I must learn to indent my code consistenly. Sorry about that and for all the things that are not correct.

  0
• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey Slideur, good job with this challenge. Keep up the good work.

  Your solution looks close to the design however in order to get the box-shadow you can use the box-shadow property. I recommend reading up on it just to ensure that you are specifying the correct values.

  https://www.w3schools.com/cssref/css3_pr_box-shadow.asp

  In terms of your accessibility issues, simply wrap all your content between <main> tags and the error should disappear.

  I hope this helps

  Cheers, Happy coding 👍

  Marked as helpful

  0
• 

  Slideur•180

  @SlideurPosted over 2 years ago

  Hey,

  Thank you for your comment and your help. I will try to use the box-shadow with the explanation of the site that you indicated to me.

  Regards,

  0