HTML & CSS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  Great work Zeek and congrats on submitting your first solution! I've got a couple of small recommendations:

  • I'd avoid using IDs for styling. They can't be reused on the same page and are too specific. Instead, I'd stick to class, attribute, pseudo, and type selectors.
  • Rather than having the min-height media query, I'd instead just add min-height: 100vh; to the body for this design, which would mean it would automatically grow for the mobile layout and stay 100% the viewport height for the grid layout.

  I hope that helps! Keep up the great work!

  0

  ---

  

  Zeek•430

  @odkpatrickPosted about 5 years ago

  I really appreciate the recommendations, thank you!

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 5 years ago

  @odkpatrick you're welcome!

  0