
Design comparison
Community feedback
- @spalquiPosted 8 days ago
I like your HTML structure although it could include semantic HTML such as a
main
tag andarticle
for your blog preview which better describes the content you're displaying. The class names could be more descriptive. So instead ofbox
you could have usedpost
orpost__container
. The use of BEM naming methodology ofblock__element--modifier
is often seen in industry, so it's a good way to name your classes.Having multiple style sheet files for each component is a great to way to structure your project especially as it gets big. I will play the devil's advocate here, in a very small project like this, a single style sheet would suffice.
Great use of CCS variables for colours, shows that you are aware of modern CSS features. I can also see you using CSS Grid which again supports what I previously said.
For the
box
shadow you could have used thebox-shadow
property as you could have done it all in one line.Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord