HTML & CSS

Community feedback

• 

  buchi•60

  @buchi-1996Posted almost 4 years ago

  Thanks guys

  0
• 

  David Payne•1,205

  @dpayne713Posted almost 4 years ago

  Hey Buchi. I like to use REM as it references the root and scales for people who change their browser default font size.

  Check out this Link about it I found on the CSS tricks website

  https://snook.ca/archives/html_and_css/font-size-with-rem

  0

  ---

  

  buchi•60

  @buchi-1996Posted almost 4 years ago

  @dpayne713 thanks a lot for this I will use this convention from now on.

  0
• 

  Aleksandr Aksenov•750

  @axevldkPosted almost 4 years ago

  Hi, @buchi ~ I have studied your work, and great work so far ~ Especially BEM naming is good. Here are some of my opinions.

  1. You can add min-height: 100vh; to body element, so that it can fit whole screen.

  2. In the top left text section paragraph is settled inside h1 tag. I am not sure why you did so, but this isn't good for HTML semantic rule.

  3. You used images tags for background but I think it would be better to use background-image css property or pseudo elements in such cases.

  4. You can set max-width: 1280px; margin: 0 auto; to your container element.

  Hope this will help you even a bit. Happy coding ~ ✨

  0

  ---

  

  buchi•60

  @buchi-1996Posted almost 4 years ago

  @axevldk thanks a lot.. I don't know how to position background images especially svgs. please how do I go about this.

  0