HTML & CSS with Grid layouts

Community feedback

• 

  Gerben Dol•3,115

  @GerbenDolPosted over 4 years ago

  Hey Elena, great to see another one of your solutions! You did a really good job! 💪🏻

  Some things I noticed:

  • The .main isn't always the full browser height, which I think would look better. Try changing the height from 100% to 100vh
  • The radius of your border will get stretched out a bit weirdly. Maybe try setting a fixed height to your input and also a fixed border-radius (which would be half the value of the height)
  • I think exactly matching the background image is almost impossible, but I what I did notice in the design is that behind the wavy background there's also a gradient applied to the page. You'll find that that really helps getting it closer to the original design. The gradient is listed in the design briefing. 🤓
  • Give the smaller sized screens (not mobile, but for instance tablet) a bit more love 😁

  I know it's a bit much, but they're details. Keep up the great work, I'm hoping to see another one of your solutions soon! 🙌🏻

  1

  ---

  

  Elena Stagg•220

  @elenastaggPosted over 4 years ago

  @GerbenDol Hi there, thanks for your feedback again, really helpful. Ah - I hadn't worked out the gradient was for the background. Great tip on the border, that saves quite a few lines of code. Cheers!

  1