@Islandstone89
Posted
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change.containerto a<main>. -
"Learn More" would navigate to another page, hence it is not a button but a link.
-
.attributionshould be a<footer>, and its text must be wrapped in a<p>.
CSS:
-
Performance-wise, it's better to link fonts in the
<head>of the HTML than using@import. -
It's good practice to include a CSS Reset at the top.
-
Add around
1remofpaddingon thebody, so the card doesn't touch the edges on small screens. -
Change
heighttomin-height- this way, the content will not get cut off if it grows beneath the viewport. -
Media queries should be in rem.
Marked as helpful
