HTML and CSS with a bit flexbox

Community feedback

• 

  Hexer•3,660

  @EmmanuelHexerPosted almost 3 years ago

  Great job overall man.

  • To fix your accessibility issues wrap your card with main element.

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Fahim Good Job on challenge

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body <main class="container"></main>

  -> Learn more on accessibility issues

  If this comment helps you then pls mark it as helpful!

  Have a good day and keep coding 👍!

  0
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted almost 3 years ago

  Hey there,

  Well done, it looks pretty close! You can get rid of the accessibility issues in the report by swapping your h2 with h1 and your attribution div with footer. This is pretty optional, as it's just a small component (and hypothetically part of a bigger website, where there's probably an h1 somewhere else, etc). I tend to get rid of these report issues as they bother me but it's up to you in this case.

  The other thing is, I'd advise you against setting your font size in px, as px won't be able to scale if a user changes the browser's default font-size.

  Other than this, well done ^^

  0