Hexer• 3,660
@Phalcin
Posted
Great job overall man.
- To fix your accessibility issues wrap your card with
mainelement.
0
Design comparison
Solution retrospective
I guess it was the easiest challenge for me, and also completed the fastest. Still, I'm a beginner and any suggestion is of great help to me.
Community feedback
Naveen Gumaste• 10,480
@NaveenGumaste
Posted
Hay ! Fahim Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body <main class="container"></main>
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
0
P
Fluffy Kas• 7,735
@FluffyKas
Posted
Hey there,
Well done, it looks pretty close! You can get rid of the accessibility issues in the report by swapping your h2 with h1 and your attribution div with footer. This is pretty optional, as it's just a small component (and hypothetically part of a bigger website, where there's probably an h1 somewhere else, etc). I tend to get rid of these report issues as they bother me but it's up to you in this case.
The other thing is, I'd advise you against setting your font size in px, as px won't be able to scale if a user changes the browser's default font-size.
Other than this, well done ^^
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord