HTML & CSS USING GRID

Community feedback

• 

  Arturo Simon•1,785

  @artimysPosted almost 4 years ago

  Nice job job Harold, looks good and is responsive. 👍

  I noticed something is generating a horizontal scrollbar on your page. I think width: 100vw on your .banner-container is causing it.

  Observations:

  • You're missing some <li> tags for the footer social icons and also wrap the icons with an anchor tag.
  • Lighten the box-shadow color a bit so it's not so intense
  • For the footer phone number and email. Wrap them with an anchor tag and maybe add the prefix in the href to let the browser know the links are an email and phone number

  <a href="tel:+1-543-123-4567">
      <img />
      +1-543-123-4567
  </a>
  <a href="mailto:[email protected]">
      <img />
      [email protected]
  </a>
  

  • Add a max-width to your desktop layout main container.

  On mobile I think the main container can use a little little bit more left and right padding so it's not too close to the viewport sides.

  Keep it up 👍👍

  0

  ---

  

  Harold•628

  @harika09Posted almost 4 years ago

  @artimys thank you for the feedback! I will fix it soon. Thanks!

  0