@ManuGil22
Posted
Hey Kohsey!
Im pretty new to html and css too but have some feedback:
- Im not sure which aproach is correct but i would rather use an <h1> tag instead of a <p> for the title.
- Not need to have <div> outside the paragraphs. As I told you before im pretty new too but think its just no needed. Divs are mostly used to customize and style some sections, for e.g. if you want to change the background-color of the title. In this case you are not doing anything with them so, there just extra lines.
- One of the accessibility issues you have is that every <img> tag should have an alternate text. Its used by screenreaders as a description of the image. I would do smth like alt="qr code".
- Also u have an accessibility issue that its not important but u might want to fix it. It says you should have a main landmark in ur code. That can be easily fixed by adding a <main> tag around the div with id="block". Just like this:
<main>
<div id="block">
....
</div>
</main>
There are all details, nothing big. You made an amazing work there!
Keep pushing and happy coding!
Marked as helpful
@KohseyPower
Posted
@ManuGil22 Thanks for the feed back Manuel !! I got it, I will fix these issues !