Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML and CSS solution

Momshad Islamβ€’ 10

@Shad-Islam

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Kindly share your feedback with me. It would be highly appreciated.

Community feedback

Daniel πŸ›Έβ€’ 44,230

@danielmrz-dev

Posted

Hello @Shad-Islam!

Your solution looks great!

I have a couple of suggestions for improvement:

  • First: In order to make your HTML code more semantic, use <h1> for the main title instead of <h3>. Unlike what most people think, it's not just about the size and weight of the text.

πŸ“Œ The <h1> to <h6> tags are used to define HTML headings.

πŸ“Œ <h1> defines the most important heading.

πŸ“Œ <h6> defines the least important heading.

πŸ“Œ Only use one <h1> per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with <h1>, then use <h2>, and so on.

  • Second: Still about semantic HTML, use <main> to wrap the main content instead of <div>.

All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0
Enoch Beamahnβ€’ 80

@djamkenny

Posted

I think you have a high border-radius i think 20px could be more better. But you have done so well i checked your responsiveness and it cool

Marked as helpful

0

Momshad Islamβ€’ 10

@Shad-Islam

Posted

@djamkenny Thank you so much for your feedback! I appreciate your positive comments and I'm thrilled to hear that the responsiveness checked out well.

Regarding the border-radius, your suggestion makes sense. I'll certainly consider it and make the adjustment to 20px for both the .card and .qr-code elements. Your insights are valuable, and I'm always eager to refine my work based on constructive feedback.

Thanks again for taking the time to review my project. If you have any further suggestions or feedback, feel free to shareβ€”I'm eager to learn and improve!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord