HTML And CSS

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 9 months ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change .container to a <main>.

  • The alt text should be written naturally, without using - between the words. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor.io).

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

  • Add justify-content: center on body.

  • Remove the margin on .container.

  • Move the max-width to .card. It should also be in rem - 20rem works fine.

  • Remove margin on .card.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

  • .text h3 should be text h2. However, you don't need to write .text in front of the selectors; a better way is to give the elements a class.

  Marked as helpful

  0

  ---

  

  SIRSAMUEL014•100

  @SIRSAMUEL014Posted 8 months ago

  Thank you for the feedback @Islandstone89

  1